Re: [PATCH 1/2] submodule-config: keep shallow recommendation around

From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: May 26, 2016, 09:02 UTC
Message-ID: <2022441346.44059.1464253372857.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <20160526000633.27223-2-sbeller@google.com>

Hi Stefan,

Stefan Beller <sbeller@google.com> writes:

Show 8 quoted lines

> [...]
> @ -353,6 +354,15 @@ static int parse_config(const char *var, const char *value, void *data)
>                  else if (parse_submodule_update_strategy(value,
>                           &submodule->update_strategy) < 0)
>                                  die(_("invalid value for %s"), var);
> +        } else if (!strcmp(item.buf, "shallow")) {
> +                if (!me->overwrite &&
> +                         submodule->recommend_shallow != -1)

Nit: You seems to be able to keep the whole condition on the same line:

		if (!me->overwrite && submodule->recommend_shallow != -1)

If you want to keep it in two line, you might want to align it:
		if (!me->overwrite &&
		    submodule->recommend_shallow != -1)

Thanks, Rémi