Re: [PATCH 2/2] t6500: mark tests as SHA1 reliant
- From
Stefan Beller <sbeller@google.com>
- Date
- Jul 31, 2017, 20:26 UTC
- Message-ID
- <CAGZ79kaBUpVwymjmzmOtHgfiWyxPQZCtFOX_Zm5v7N-H+C9cNA@mail.gmail.com>
- In-Reply-To
- <20170730232427.vrqrrhlsap55ax7t@genre.crustytoothpaste.net>
On Sun, Jul 30, 2017 at 4:24 PM, brian m. carlson <sandals@crustytoothpaste.net> wrote:
Show 20 quoted lines
> On Sun, Jul 30, 2017 at 11:00:19PM +0000, brian m. carlson wrote: >> Yes, basically, but a bit more generally. There will always be cases in >> which we need to specify an object ID or an arbitrary string and the >> behavior will need to vary based on the hash. That can be something >> like, in this case, the two blob contents that would have the similar >> prefix. >> >> So in this case, we pass the helper the string "263 410" and get back a >> value for either the hacked SHA-1 hash or the SHA-256 or whatever we're >> using. > > I realize this was worded poorly. So for my example, in this case, we'd > do: > > test-helper-hash-string "263 410" > > For SHA-1, we'd get "263 410". For SHA-256, we'd get "313 481" (which, > as SHA-256 blobs, both start with "17" in their hex representation). > Presumably we'd read some environment variable to determine the proper > value.
This is what Junio proposed in the first message, except that we defer that to a shell script as for each test we may need different things, so a helper may be of little value?