git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t6500: mark tests as SHA1 reliant

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jul 30, 2017, 23:24 UTC
Message-ID
<20170730232427.vrqrrhlsap55ax7t@genre.crustytoothpaste.net>
In-Reply-To
<20170730230019.ch74ska6wgbrh7ql@genre.crustytoothpaste.net>
On Sun, Jul 30, 2017 at 11:00:19PM +0000, brian m. carlson wrote:
Show 9 quoted lines
> Yes, basically, but a bit more generally.  There will always be cases in
> which we need to specify an object ID or an arbitrary string and the
> behavior will need to vary based on the hash.  That can be something
> like, in this case, the two blob contents that would have the similar
> prefix.
> 
> So in this case, we pass the helper the string "263 410" and get back a
> value for either the hacked SHA-1 hash or the SHA-256 or whatever we're
> using.

I realize this was worded poorly. So for my example, in this case, we'd do:

test-helper-hash-string "263 410"

For SHA-1, we'd get "263 410". For SHA-256, we'd get "313 481" (which, as SHA-256 blobs, both start with "17" in their hex representation). Presumably we'd read some environment variable to determine the proper value.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
Previous: brian m. carlsonNext: Ævar Arnfjörð Bjarmason
Message 11 of 15 in “How to migrate our test infrastructure away from sha1”
  1. 0/2 How to migrate our test infrastructure away from sha1Stefan Beller, Jul 28, 2017
  2. 1/2 alter hash function: expose test dependencies on sha1Stefan Beller, Jul 28, 2017
  3. Junio C HamanoJul 28, 2017
  4. 2/2 t6500: mark tests as SHA1 reliantStefan Beller, Jul 28, 2017
  5. Junio C HamanoJul 28, 2017
  6. Stefan BellerJul 28, 2017
  7. Junio C HamanoJul 28, 2017
  8. brian m. carlsonJul 29, 2017
  9. Junio C HamanoJul 30, 2017
  10. brian m. carlsonJul 30, 2017
  11. brian m. carlsonJul 30, 2017
  12. Ævar Arnfjörð BjarmasonJul 31, 2017
  13. Stefan BellerJul 31, 2017
  14. Stefan BellerJul 31, 2017
  15. brian m. carlsonJul 31, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.