Re: [PATCH 2/6] submodule update --init: correct path handling in recursive submodules

From: Stefan Beller <sbeller@google.com>
Date: Mar 30, 2016, 01:00 UTC
Message-ID: <CAGZ79ka3ZL8Avs4gt5ODtQQh7o2TFQAj2RQEJz3SdYV7_Z1Oqw@mail.gmail.com>
In-Reply-To: <xmqqoa9wvo0w.fsf@gitster.mtv.corp.google.com>

On Tue, Mar 29, 2016 at 4:54 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>> The new test demonstrates a failure in the code prior to this patch.
>> Instead of getting the expected
>>     Submodule 'submodule' (${pwd}/submodule) registered for path '../super/submodule'
>> the `super` directory is omitted and you get
>>     Submodule 'submodule' (${pwd}/submodule) registered for path '../submodule'
>> instead.
>
> Same "is this about test?" comment applies here.
>
>> That happens because the prefix is ignored in `git submodule add`, probably
>> because that function itself cannot recurse;
>
> "probably"???

I am speculating there. I have no idea why it originally was written that way but I would assume this is the most likeliest explanation. I'll reword the whole commit message.

Show 5 quoted lines

>
>>
>> +supersha1=$(cd super && git rev-parse HEAD)
>
> Perhaps "git -C super rev-parse HEAD"?

done