git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/6] t7407: make expectation as clear as possible

From
Stefan Beller <sbeller@google.com>
Date
Mar 29, 2016, 23:02 UTC
Message-ID
<1459292558-5840-7-git-send-email-sbeller@google.com>
In-Reply-To
<1459292558-5840-1-git-send-email-sbeller@google.com>

Not everyone (including me) grasps the sed expression in a split second as they would grasp the 4 lines printed as is.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 t/t7407-submodule-foreach.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/t/t7407-submodule-foreach.sh b/t/t7407-submodule-foreach.sh
index 4b35e12..6ba5daf 100755
--- a/t/t7407-submodule-foreach.sh
+++ b/t/t7407-submodule-foreach.sh
@@ -262,8 +262,12 @@ test_expect_success 'test "status --recursive"' '
 	test_cmp expect actual
 '
 
-sed -e "/nested2 /s/.*/+$nested2sha1 nested1\/nested2 (file2~1)/;/sub[1-3]/d" < expect > expect2
-mv -f expect2 expect
+cat > expect <<EOF
+ $nested1sha1 nested1 (heads/master)
++$nested2sha1 nested1/nested2 (file2~1)
+ $nested3sha1 nested1/nested2/nested3 (heads/master)
+ $submodulesha1 nested1/nested2/nested3/submodule (heads/master)
+EOF
 
 test_expect_success 'ensure "status --cached --recursive" preserves the --cached flag' '
 	(
-- 
2.8.0.6.g3d0b0ba
Previous: Stefan Beller
Message 12 of 12 in “[PATCHv3 0/6] Fix path bugs in submodule commands executed from sub dir”
  1. Stefan BellerMar 29, 2016
  2. 1/6 submodule foreach: correct path display in recursive submodulesStefan Beller, Mar 29, 2016
  3. Junio C HamanoMar 29, 2016
  4. 2/6 submodule update --init: correct path handling in recursive submodulesStefan Beller, Mar 29, 2016
  5. Junio C HamanoMar 29, 2016
  6. Stefan BellerMar 30, 2016
  7. 3/6 submodule status: correct path handling in recursive submodulesStefan Beller, Mar 29, 2016
  8. Junio C HamanoMar 29, 2016
  9. 4/6 submodule update: align reporting path for custom command executionStefan Beller, Mar 29, 2016
  10. Junio C HamanoMar 29, 2016
  11. 5/6 submodule update: test recursive path reporting from subdirectoryStefan Beller, Mar 29, 2016
  12. 6/6 t7407: make expectation as clear as possibleStefan Beller, Mar 29, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.