git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 0/4] recursive submodules: git-reset!

From
Stefan Beller <sbeller@google.com>
Date
Apr 20, 2017, 20:00 UTC
Message-ID
<CAGZ79kZxfAJDQ96QngOCSp1q6kepgcByv7zSkRn_aFL3CLcznQ@mail.gmail.com>
In-Reply-To
<20170420194130.GF142567@google.com>
On Thu, Apr 20, 2017 at 12:41 PM, Brandon Williams <bmwill@google.com> wrote:
Show 8 quoted lines
> On 04/18, Stefan Beller wrote:
>> v2:
>> * improved commit message to be proper English (Thanks, Philip!)
>> * clarified why the patch 2 is so short (i.e. it doesn't matter if the submodule
>>   is initialized in the preparation repo, we care about the actual testing repo!
>>   Thanks, Brandon)
>
> That was the only thing I was unsure about in v1. v2 lgtm.
Thanks for the review.

Well the last commit still needs a better commit message as Junio pointed out, so might just resend the last patch with better wording.

Previous: Brandon Williams
Message 10 of 10 in “[PATCHv2 0/4] recursive submodules: git-reset!”
  1. Stefan BellerApr 18, 2017
  2. 1/4 entry.c: submodule recursing: respect force flag correctlyStefan Beller, Apr 18, 2017
  3. 2/4 submodule.c: uninitialized submodules are ignored in recursive commandsStefan Beller, Apr 18, 2017
  4. 3/4 submodule.c: submodule_move_head works with broken submodulesStefan Beller, Apr 18, 2017
  5. 4/4 builtin/reset: add --recurse-submodules switchStefan Beller, Apr 18, 2017
  6. Junio C HamanoApr 19, 2017
  7. Stefan BellerApr 19, 2017
  8. 4/4 builtin/reset: add --recurse-submodules switchStefan Beller, Apr 21, 2017
  9. Brandon WilliamsApr 20, 2017
  10. Stefan BellerApr 20, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.