Re: [RFC/PATCH 1/7] rerere: unify error message when read_cache fails
- From
Stefan Beller <sbeller@google.com>
- Date
- May 21, 2018, 19:00 UTC
- Message-ID
- <CAGZ79kZnMnG_88YC8bfopfw8o9qwTggC01HPSPddL+LU-QVjFQ@mail.gmail.com>
- In-Reply-To
- <20180520211210.1248-2-t.gummerer@gmail.com>
On Sun, May 20, 2018 at 2:12 PM, Thomas Gummerer <t.gummerer@gmail.com> wrote:
Show 20 quoted lines
> We have multiple different variants of the error message we show to > the user if 'read_cache' fails. The "Could not read index" variant we > are using in 'rerere.c' is currently not used anywhere in translated > form. > > As a subsequent commit will mark all output that comes from 'rerere.c' > for translation, make the life of the translators a little bit easier > by using a string that is used elsewhere, and marked for translation > there, and thus most likely already translated. > > "index file corrupt" seems to be the most common error message we show > when 'read_cache' fails, so use that here as well. > > Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com> > --- > > "index file corrupt" is also what Stefan chose for his series unifying > these error messages (and 'die'ing, which I'm not sure is the right > thing to do here as also mentioned in my reply to [1]). I'm happy to > drop this if we decide to go with that series.
Acked-by: <me>
I'd happily have this patch instead of the one in my series.
I was about to ask for translation, but the commit message hints at a follow up patch marking this for translation, so I'll read on.
Stefan