[PATCH v2 10/10] rerere: recalculate conflict ID when unresolved conflict is committed
- From
Thomas Gummerer <t.gummerer@gmail.com>
- Date
- Jun 5, 2018, 21:52 UTC
- Message-ID
- <20180605215219.28783-11-t.gummerer@gmail.com>
- In-Reply-To
- <20180605215219.28783-1-t.gummerer@gmail.com>
Currently when a user doesn't resolve a conflict, commits the results, and does an operation which creates another conflict, rerere will use the ID of the previously unresolved conflict for the new conflict. This is because the conflict is kept in the MERGE_RR file, which 'rerere' reads every time it is invoked.
After the new conflict is solved, rerere will record the resolution with the ID of the old conflict. So in order to replay the conflict, both merges would have to be re-done, instead of just the last one, in order for rerere to be able to automatically resolve the conflict.
Instead of that, assign a new conflict ID if there are still conflicts in a file and the file had conflicts at a previous step. This ID matches the conflict we actually resolved at the corresponding step.
Note that there are no backwards compatibility worries here, as rerere would have failed to even normalize the conflict before this patch series.
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com> --- rerere.c | 7 +++---- t/t4200-rerere.sh | 7 +++++++ 2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/rerere.c b/rerere.c index f611db7873..644f185180 100644 --- a/rerere.c +++ b/rerere.c @@ -818,7 +818,7 @@ static int do_plain_rerere(struct string_list *rr, int fd) struct rerere_id *id; unsigned char sha1[20]; const char *path = conflict.items[i].string; - int ret, has_string; + int ret; /* * Ask handle_file() to scan and assign a @@ -826,12 +826,11 @@ static int do_plain_rerere(struct string_list *rr, int fd) * yet. */ ret = handle_file(path, sha1, NULL); - has_string = string_list_has_string(rr, path); - if (ret < 0 && has_string) { + if (ret != 0 && string_list_has_string(rr, path)) { remove_variant(string_list_lookup(rr, path)->util); string_list_remove(rr, path, 1); } - if (ret < 1 || has_string) + if (ret < 1) continue; id = new_rerere_id(sha1); diff --git a/t/t4200-rerere.sh b/t/t4200-rerere.sh index f433848ccb..9578215ff2 100755 --- a/t/t4200-rerere.sh +++ b/t/t4200-rerere.sh @@ -636,6 +636,13 @@ test_expect_success 'rerere with inner conflict markers' ' git commit -q -m "will solve conflicts later" && test_must_fail git merge A && cat test >actual && + test_cmp expect actual && + + git add test && + git commit -m "rerere solved conflict" && + git reset --hard HEAD~ && + test_must_fail git merge A && + cat test >actual && test_cmp expect actual '
-- 2.17.0.410.g65aef3a6c4