Re: [PATCH 3/3] Introduce submodule.recurse option
- From
Stefan Beller <sbeller@google.com>
- Date
- May 18, 2017, 16:20 UTC
- Message-ID
- <CAGZ79kZjMwoXOr_5xrU0Uy9K5bjJOd=YUBvK+Dpx+uS+5LH9Dw@mail.gmail.com>
- In-Reply-To
- <20170518153901.GB112091@google.com>
On Thu, May 18, 2017 at 8:39 AM, Brandon Williams <bmwill@google.com> wrote:
Show 10 quoted lines
> On 05/17, Stefan Beller wrote: >> Any command that understands the boolean --recurse-submodule=[true/false] >> can have its default changed to true, by setting the submodule.recurse >> option. >> >> git-push takes a --recurse-submodule argument but it is not boolean, >> hence it is not included (yet?). > > ls-files and grep could also be added. They don't need to be added in > this patch though.
I agree for git-grep. git-ls-files is a pure plumbing command, which usually are not very accepting of options. Then it is easier for script writers to rely on its expected output.
I just missed those two (at least grep) and will add them in this patch if we think this series is a good idea going forward.
Thanks, Stefan