git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] submodule.c: add has_submodules to check if we have any submodules

From
Stefan Beller <sbeller@google.com>
Date
May 18, 2017, 16:38 UTC
Message-ID
<CAGZ79kZZF7L0Wv5kPO+LxM6_7tA=DrD2RSn9SM708yvnxPnW3A@mail.gmail.com>
In-Reply-To
<20170518153508.GA112091@google.com>
Show 9 quoted lines
>> +static enum {
>> +     SUBMODULE_CONFIG_NOT_READ = 0,
>> +     SUBMODULE_CONFIG_NO_CONFIG,
>> +     SUBMODULE_CONFIG_EXISTS,
>> +} submodule_config_reading;
>
> Any way we can have this not be a global, but rather a parameter?  You
> could pass in a pointer to this value via the callback data parameter in
> the submodule_config function.

As said in the reply to Junio, this patch has been sitting on my hard drive for a while and was written before you started the attempt to de-globalize the state of git.

Ideally this setting would be part of the repository object. For example the repository object would have a "submodule_config" pointer, initialized to NULL, which can then be set to the read config or a static empty_config if no such config exists.

Previous: Brandon WilliamsNext: Brandon Williams
Message 7 of 13 in “Add option to recurse into submodules”
  1. 0/3 Add option to recurse into submodulesStefan Beller, May 17, 2017
  2. 2/3 submodule test invocation: only pass additional argumentsStefan Beller, May 17, 2017
  3. 1/3 submodule.c: add has_submodules to check if we have any submodulesStefan Beller, May 17, 2017
  4. Junio C HamanoMay 18, 2017
  5. Stefan BellerMay 18, 2017
  6. Brandon WilliamsMay 18, 2017
  7. Stefan BellerMay 18, 2017
  8. Brandon WilliamsMay 18, 2017
  9. Stefan BellerMay 18, 2017
  10. 3/3 Introduce submodule.recurse optionStefan Beller, May 17, 2017
  11. Brandon WilliamsMay 18, 2017
  12. Stefan BellerMay 18, 2017
  13. Brandon WilliamsMay 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.