git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 4/6] list-objects: filter objects in traverse_commit_list

From
Stefan Beller <sbeller@google.com>
Date
Nov 22, 2017, 22:56 UTC
Message-ID
<CAGZ79kZR-W-_JJi7zptiGgv=W7KpNMaSEbmmxrXcKovznK9E7Q@mail.gmail.com>
In-Reply-To
<20171121205852.15731-5-git@jeffhostetler.com>
On Tue, Nov 21, 2017 at 12:58 PM, Jeff Hostetler <git@jeffhostetler.com> wrote:
> +       assert(arg);
> +       assert(!unset);

I count 16 asserts in this patch. Is that really needed? Either omit them or use BUG if we want to rely on user bug reports when these conditions trigger, as assert is unreliable due to its dependence on the NDEBUG flag.

Stefan
Previous: Jeff HostetlerNext: Jeff Hostetler
Message 9 of 14 in “Partial clone part 1: object filtering”
  1. 0/6 Partial clone part 1: object filteringJeff Hostetler, Nov 21, 2017
  2. 3/6 oidset: add iterator methods to oidsetJeff Hostetler, Nov 21, 2017
  3. 5/6 rev-list: add list-objects filtering supportJeff Hostetler, Nov 21, 2017
  4. Jonathan NiederNov 22, 2017
  5. Jeff HostetlerNov 29, 2017
  6. 6/6 pack-objects: add list-objects filteringJeff Hostetler, Nov 21, 2017
  7. 1/6 dir: allow exclusions from blob in addition to fileJeff Hostetler, Nov 21, 2017
  8. 4/6 list-objects: filter objects in traverse_commit_listJeff Hostetler, Nov 21, 2017
  9. Stefan BellerNov 22, 2017
  10. Jeff HostetlerNov 27, 2017
  11. Jeff KingNov 30, 2017
  12. 2/6 oidmap: add oidmap iterator methodsJeff Hostetler, Nov 21, 2017
  13. Jonathan TanNov 22, 2017
  14. Junio C HamanoNov 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.