git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 0/6] Partial clone part 1: object filtering

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Nov 22, 2017, 01:37 UTC
Message-ID
<20171121173754.12ae87e8bfdd773efada98e3@google.com>
In-Reply-To
<20171121205852.15731-1-git@jeffhostetler.com>

On Tue, 21 Nov 2017 20:58:46 +0000 Jeff Hostetler <git@jeffhostetler.com> wrote:

Show 15 quoted lines
> From: Jeff Hostetler <jeffhost@microsoft.com>
> 
> Here is V5 of the list-object filtering, rev-list, and pack-objects.
> 
> This version addresses comments on the V4 series.  I removed the
> questionable character encoding scheme.  And I removed or clarified
> use of the term "partial clone" to refer to a future feature.
> 
> Jeff Hostetler (6):
>   dir: allow exclusions from blob in addition to file
>   oidmap: add oidmap iterator methods
>   oidset: add iterator methods to oidset
>   list-objects: filter objects in traverse_commit_list
>   rev-list: add list-objects filtering support
>   pack-objects: add list-objects filtering
I checked the diff against v4 and this looks good.

I'm still unsure if pre-parsing the --filter argument into a struct list_objects_filter_options is the best approach API-wise in the case that we plan to send it to the server, but it does have the benefit of failing (and informing the user) early if the filter is in the wrong format, so I'm fine with this patch set as-is.

Previous: Jeff HostetlerNext: Junio C Hamano
Message 13 of 14 in “Partial clone part 1: object filtering”
  1. 0/6 Partial clone part 1: object filteringJeff Hostetler, Nov 21, 2017
  2. 3/6 oidset: add iterator methods to oidsetJeff Hostetler, Nov 21, 2017
  3. 5/6 rev-list: add list-objects filtering supportJeff Hostetler, Nov 21, 2017
  4. Jonathan NiederNov 22, 2017
  5. Jeff HostetlerNov 29, 2017
  6. 6/6 pack-objects: add list-objects filteringJeff Hostetler, Nov 21, 2017
  7. 1/6 dir: allow exclusions from blob in addition to fileJeff Hostetler, Nov 21, 2017
  8. 4/6 list-objects: filter objects in traverse_commit_listJeff Hostetler, Nov 21, 2017
  9. Stefan BellerNov 22, 2017
  10. Jeff HostetlerNov 27, 2017
  11. Jeff KingNov 30, 2017
  12. 2/6 oidmap: add oidmap iterator methodsJeff Hostetler, Nov 21, 2017
  13. Jonathan TanNov 22, 2017
  14. Junio C HamanoNov 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.