Re: [PATCH v2 01/12] commit.c: use strchrnul() to scan for one line

From: Stefan Beller <sbeller@google.com>
Date: May 16, 2016, 23:46 UTC
Message-ID: <CAGZ79kZMsHrw+B29i6e4eWjVhEgH01H8QuNPA9_-CikGmQKVvQ@mail.gmail.com>
In-Reply-To: <CAPc5daXM9a=W2R6YE=4PSuHWKXoZs_-VT+48ajh3mq1RoqYncA@mail.gmail.com>

On Mon, May 16, 2016 at 4:41 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> On Mon, May 16, 2016 at 4:19 PM, Stefan Beller <sbeller@google.com> wrote:
>>>         if (*p) {
>>>                 p += 2;
>>> -               for (eol = p; *eol && *eol != '\n'; eol++)
>>> -                       ; /* do nothing */
>>> +               eol = strchrnul(p, '\n');
>>
>> Nit:
>> You could include the +2 into the arg of  strchrnul,
>> such that you can drop the braces.
>
> You're right. With or without braces,
>
>   eol = strchrnul(p + 2, '\n');
>
> would be easier to understand (I do not know offhand if the value of p
> matters after this part, as I am responding from GMail Web UI without
> access to the wider context in the source, though).

Heh, good point, I did not think it through apparently. `p` matters.