Re: [PATCH v2 00/12] revamping git_check_attr() API

From: Stefan Beller <sbeller@google.com>
Date: May 18, 2016, 16:51 UTC
Message-ID: <CAGZ79kYLVDkeHUMCxOB57YYeJt3f4O8csEp_tyO-oWMTzJ-9hw@mail.gmail.com>
In-Reply-To: <20160516210545.6591-1-gitster@pobox.com>

> The patches in the earliest part of the series have been sent to the
> list already; there is no substantial change (I think I made a
> typofix in the commit log message found by Eric).

and a new patch got added here:

    attr.c: tighten constness around "git_attr" structure

I cannot find it on the list though? (I only see it in the "What's cooking" email and on origin/jc/attr)

Minor nit: So I wondered when you prefix the subject of the patches with "attr.c:" and when with "attr:". All patches with "attr.c" prefixed touch only that file, the others will change the attr system beyond that file scope. However the "tighten constness" touches the header file, too. So you'd maybe want to loose the ".c".

Thanks, Stefan