git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] submodule-helper: fix indexing in clone retry error reporting path

From
Stefan Beller <sbeller@google.com>
Date
Jul 22, 2016, 19:50 UTC
Message-ID
<CAGZ79kZCt2iZNc7VkkcW1bTnwF9YrDi9zPi0p7=-7aDVe=0dzg@mail.gmail.com>
In-Reply-To
<xmqqeg6la2da.fsf@gitster.mtv.corp.google.com>
On Fri, Jul 22, 2016 at 12:39 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 28 quoted lines
> Johannes Sixt <j6t@kdbg.org> writes:
>
>> 'git submodule--helper update-clone' has logic to retry failed clones
>> a second time. For this purpose, there is a list of submodules to clone,
>> and a second list that is filled with the submodules to retry. Within
>> these lists, the submodules are identified by an index as if both lists
>> were just appended.
>>
>> This works nicely except when the second clone attempt fails as well. To
>> report an error, the identifying index must be adjusted by an offset so
>> that it can be used as an index into the second list. However, the
>> calculation uses the logical total length of the lists so that the result
>> always points one past the end of the second list.
>>
>> Pick the correct index.
>>
>> Signed-off-by: Johannes Sixt <j6t@kdbg.org>
>> ---
>
> Looks very similar to
>
>   http://public-inbox.org/git/20160721013923.17435-1-sbeller%40google.com/
>
> but these two patch series looks more thorough.
>
> I expect I'd queue these two instead, after seeing Acks from Stefan.
>
> Thanks.
Sure. Please take these 2 patches instead of mine.

Thanks, Stefan

Previous: Junio C HamanoNext: Junio C Hamano
Message 7 of 9 in “git-submodule: forward exit code of git-submodule--helper more faithfully”
  1. 1/2 git-submodule: forward exit code of git-submodule--helper more faithfullyJohannes Sixt, Jul 22, 2016
  2. 2/2 submodule-helper: fix indexing in clone retry error reporting pathJohannes Sixt, Jul 22, 2016
  3. Stefan BellerJul 22, 2016
  4. Junio C HamanoJul 22, 2016
  5. Stefan BellerJul 22, 2016
  6. Junio C HamanoJul 22, 2016
  7. Stefan BellerJul 22, 2016
  8. Junio C HamanoJul 22, 2016
  9. Stefan BellerJul 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.