From: Stefan Beller Date: Fri, 22 Jul 2016 19:50:13 GMT Subject: Re: [PATCH 2/2] submodule-helper: fix indexing in clone retry error reporting path Message-ID: In-Reply-To: On Fri, Jul 22, 2016 at 12:39 PM, Junio C Hamano wrote: > Johannes Sixt writes: > >> 'git submodule--helper update-clone' has logic to retry failed clones >> a second time. For this purpose, there is a list of submodules to clone, >> and a second list that is filled with the submodules to retry. Within >> these lists, the submodules are identified by an index as if both lists >> were just appended. >> >> This works nicely except when the second clone attempt fails as well. To >> report an error, the identifying index must be adjusted by an offset so >> that it can be used as an index into the second list. However, the >> calculation uses the logical total length of the lists so that the result >> always points one past the end of the second list. >> >> Pick the correct index. >> >> Signed-off-by: Johannes Sixt >> --- > > Looks very similar to > > http://public-inbox.org/git/20160721013923.17435-1-sbeller%40google.com/ > > but these two patch series looks more thorough. > > I expect I'd queue these two instead, after seeing Acks from Stefan. > > Thanks. Sure. Please take these 2 patches instead of mine. Thanks, Stefan