Re: [PATCH 1/4] push options: {pre,post}-receive hook learns about push options

From: Stefan Beller <sbeller@google.com>
Date: Jul 14, 2016, 22:51 UTC
Message-ID: <CAGZ79kZ=5Jt3p5zUvve2Vy8+esWq5S8X0heGv5Unmtt_KQb8_A@mail.gmail.com>
In-Reply-To: <20160714224617.GA22386@sigill.intra.peff.net>

On Thu, Jul 14, 2016 at 3:46 PM, Jeff King <peff@peff.net> wrote:

Show 21 quoted lines

> On Thu, Jul 14, 2016 at 02:49:45PM -0700, Stefan Beller wrote:
>
>> We limit the push options for now
>> * to not exceed an arbitrary count, and
>> * to not exceed an arbitrary size.
>>
>> This serves two purposes:
>> * DoS protection (i.e. one connection can add no more than 32kB
>>   now)
>> * We need to figure out how to handle large (>64kB). Jeff wrote:
>>   > Yes, but people are also happy when they can use a flexible and
>>   > standardized tool to do a thing. I'd be more frustrated when I found out
>>   > that Git's data-pushing protocol has arbitrary limitations (like, say, I
>>   > can't push a data item larger than a single 64K pkt-line), which would
>>   > easily just work with something like HTTP POSTs.
>>   So to keep a way open in the future to deal with large pay loads,
>>   the size is restricted for now.
>
> Should this bit get dropped from the commit message?
>
> -Peff

Right. :/