git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] push options: {pre,post}-receive hook learns about push options

From
Jeff King <peff@peff.net>
Date
Jul 14, 2016, 22:46 UTC
Message-ID
<20160714224617.GA22386@sigill.intra.peff.net>
In-Reply-To
<20160714214948.27432-2-sbeller@google.com>
On Thu, Jul 14, 2016 at 02:49:45PM -0700, Stefan Beller wrote:
Show 15 quoted lines
> We limit the push options for now
> * to not exceed an arbitrary count, and
> * to not exceed an arbitrary size.
> 
> This serves two purposes:
> * DoS protection (i.e. one connection can add no more than 32kB
>   now)
> * We need to figure out how to handle large (>64kB). Jeff wrote:
>   > Yes, but people are also happy when they can use a flexible and
>   > standardized tool to do a thing. I'd be more frustrated when I found out
>   > that Git's data-pushing protocol has arbitrary limitations (like, say, I
>   > can't push a data item larger than a single 64K pkt-line), which would
>   > easily just work with something like HTTP POSTs.
>   So to keep a way open in the future to deal with large pay loads,
>   the size is restricted for now.
Should this bit get dropped from the commit message?
-Peff
Previous: Stefan BellerNext: Stefan Beller
Message 3 of 8 in “[PATCHv7 0/4] Push options”
  1. Stefan BellerJul 14, 2016
  2. 1/4 push options: {pre,post}-receive hook learns about push optionsStefan Beller, Jul 14, 2016
  3. Jeff KingJul 14, 2016
  4. Stefan BellerJul 14, 2016
  5. 2/4 receive-pack: implement advertising and receiving push optionsStefan Beller, Jul 14, 2016
  6. 3/4 push: accept push optionsStefan Beller, Jul 14, 2016
  7. 4/4 add a test for push optionsStefan Beller, Jul 14, 2016
  8. Junio C HamanoJul 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.