Re: [PATCH 14/14] rerere: convert to use the_hash_algo

From: Stefan Beller <sbeller@google.com>
Date: Oct 8, 2018, 23:18 UTC
Message-ID: <CAGZ79kZ+Kmo4QkatN7MufPy7UNT9_qb4om8J5oGB0D5aH+PtkQ@mail.gmail.com>
In-Reply-To: <20181008215701.779099-15-sandals@crustytoothpaste.net>

On Mon, Oct 8, 2018 at 2:57 PM brian m. carlson <sandals@crustytoothpaste.net> wrote:

Show 11 quoted lines

>
> Since this data is stored in the .git directory, it makes sense for us
> to use the same hash algorithm for it as for everything else.  Convert
> the remaining uses of SHA-1 to use the_hash_algo.  Use GIT_MAX_RAWSZ for
> allocations.  Rename various struct members, local variables, and a
> function to be named "hash" instead of "sha1".
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
>  rerere.c | 81 +++++++++++++++++++++++++++++---------------------------
>  1 file changed, 42 insertions(+), 39 deletions(-)

I have reviewed all patches and had minor questions on some of them, all others look good to me.

Thanks, Stefan