Re: [PATCH 06/14] packfile: express constants in terms of the_hash_algo
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Oct 9, 2018, 22:54 UTC
- Message-ID
- <20181009225410.GT432229@genre.crustytoothpaste.net>
- In-Reply-To
- <CAGZ79kbADWhuwk=7jzht5wZkESgT5ZqhhBOkGYGkC1HSSvExEA@mail.gmail.com>
On Tue, Oct 09, 2018 at 03:34:17PM -0700, Stefan Beller wrote:
Show 11 quoted lines
> On Tue, Oct 9, 2018 at 3:25 PM brian m. carlson > <sandals@crustytoothpaste.net> wrote: > > This code is mostly here on an interim basis to let us compile with a > > fully SHA-256 (no SHA-1) Git. Once that piece is done, we can move on > > to a stage 4 Git, which can do either only SHA-256, or only SHA-1, where > > we'll learn about various pack file formats and detecting the algorithm > > from them. > > This second paragraph really helps to put things into perspective, thanks! > I assume this interim base of code only applies to this patch? > (In that case maybe put it into the commit message?)
That comment will apply to most of the changes to the packfile code, whether in this series or in future series. However, after your question, I was indeed going to put it into the commit message when I reroll.
-- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204