Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

From: Stefan Beller <sbeller@google.com>
Date: Aug 1, 2017, 17:38 UTC
Message-ID: <CAGZ79kY_NdBe1QjJWrLUkfDOk8Zrnopa945F1xBq=WFDNpRWMg@mail.gmail.com>
In-Reply-To: <1501603171.1671.8.camel@gmail.com>

On Tue, Aug 1, 2017 at 8:59 AM, Kaartic Sivaraam <kaarticsivaraam91196@gmail.com> wrote:

Show 11 quoted lines

> On Mon, 2017-07-31 at 13:23 -0700, Stefan Beller wrote:
>> On Sun, Jul 30, 2017 at 9:18 AM, Kaartic Sivaraam
>> <kaarticsivaraam91196@gmail.com> wrote:
>> > Replace the dashed version of a command with undashed
>> > version and quote it.
>>
>> I like it, but similar as below, we'd want to go for
>> consistency.
>>
> I assume you mean the consistency in quoting i.e., you're expecting the
> patch to use (") instead of (') for quoting. Correct me, if I'm wrong.

Actually I did not imply any expectation on the outcome, because I do not know what the consistency end game looks like for this issue.

So maybe we'd want to go with the currently most used way? (Are there only three? (a) with dash, (b) with single quotes and (c) with double quotes?)

Show 18 quoted lines

>> >
>> > Further, remove duplicated space character.
>>
>> https://en.wikipedia.org/wiki/Sentence_spacing
>> seems like a globally controversial thing. (I assumed
>> it was some sort of local dialect before researching
>> it properly)
>>
> Man, I had no idea about people using two spaces after period.
>
>> I personally do not mind one way or another regarding
>> (double) spaces after a period, but I would think we'd
>> strive for consistency throughout the project.
>>
> Consistency is crucial. I'll just remove that part of the patch.
>
> --
> Kaartic