Re: [PATCH 1/2] doc: fix small issues in SubmittingPatches

From: Philip Oakley <philipoakley@iee.org>
Date: Jul 30, 2017, 14:49 UTC
Message-ID: <8256C530C7DE43D7BC72BFB327DF4726@PhilipOakley>
In-Reply-To: <20170730110921.11805-1-kaarticsivaraam91196@gmail.com>

From: "Kaartic Sivaraam" <kaarticsivaraam91196@gmail.com>

minor nit: It's nice, for these single character changes, to give a clue in the commit message as to what to look for.

E.g.

Quote the command, and remove duplicated space character

-- Philip.

Show 31 quoted lines

> Signed-off-by: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>
> ---
> Documentation/SubmittingPatches | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches 
> b/Documentation/SubmittingPatches
> index 558d465b6..9d0dab08d 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -293,7 +293,7 @@ then you just add a line saying
>
>         Signed-off-by: Random J Developer <random@developer.example.org>
>
> -This line can be automatically added by Git if you run the git-commit
> +This line can be automatically added by Git if you run the 'git commit'
> command with the -s option.
>
> Notice that you can place your own Signed-off-by: line when
> @@ -366,7 +366,7 @@ suggests to the contributors:
>      spend their time to improve your patch.  Go back to step (2).
>
>  (4) The list forms consensus that the last round of your patch is
> -     good.  Send it to the maintainer and cc the list.
> +     good. Send it to the maintainer and cc the list.
>
>  (5) A topic branch is created with the patch and is merged to 'next',
>      and cooked further and eventually graduates to 'master'.
> -- 
> 2.14.0.rc1.434.g6eded367a
>