Re: What's cooking in git.git (Oct 2017, #06; Fri, 27)

From: Stefan Beller <sbeller@google.com>
Date: Oct 27, 2017, 18:50 UTC
Message-ID: <CAGZ79kYUZv0g+3OEMrbT26A7mSLJzeS-yf5Knr-CnARHqVB=aQ@mail.gmail.com>
In-Reply-To: <xmqq7evhc7nw.fsf@gitster.mtv.corp.google.com>

Show 13 quoted lines

> * sb/submodule-recursive-checkout-detach-head (2017-07-28) 2 commits
>   (merged to 'next' on 2017-10-26 at 30994b4c76)
>  + Documentation/checkout: clarify submodule HEADs to be detached
>  + recursive submodules: detach HEAD from new state
>
>  "git checkout --recursive" may overwrite and rewind the history of
>  the branch that happens to be checked out in submodule
>  repositories, which might not be desirable.  Detach the HEAD but
>  still allow the recursive checkout to succeed in such a case.
>
>  Undecided.
>  This needs justification in a larger picture; it is unclear why
>  this is better than rejecting recursive checkout, for example.

We have been running this patch internally for a couple of weeks now, and had no complaints by users.

Detaching the submodule HEAD is in line with the current thinking of submodules, though I am about to send out a plan later asking if we want to keep it that way long term.

Thanks, Stefan