Re: sb/submodule-recursive-checkout-detach-head

From: Stefan Beller <sbeller@google.com>
Date: Nov 7, 2017, 17:05 UTC
Message-ID: <CAGZ79kY=WWTzwyz8t21RghEWAgPphhvUO5ut0O+rL0YhbqeGxQ@mail.gmail.com>
In-Reply-To: <xmqq4lq6hmp2.fsf_-_@gitster.mtv.corp.google.com>

On Mon, Nov 6, 2017 at 6:00 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

> Stefan Beller <sbeller@google.com> writes:
>
>>> * sb/submodule-recursive-checkout-detach-head (2017-07-28) 2 commits
>>>   (merged to 'next' on 2017-10-26 at 30994b4c76)
>>>  + Documentation/checkout: clarify submodule HEADs to be detached
>>>  + recursive submodules: detach HEAD from new state
>>>
>>>  "git checkout --recursive" may overwrite and rewind the history of
>>>  the branch that happens to be checked out in submodule
>>>  repositories, which might not be desirable.  Detach the HEAD but
>>>  still allow the recursive checkout to succeed in such a case.
>>>
>>>  Undecided.
>>>  This needs justification in a larger picture; it is unclear why
>>>  this is better than rejecting recursive checkout, for example.
>> ...
>> Detaching the submodule HEAD is in line with the current thinking
>> of submodules, though I am about to send out a plan later
>> asking if we want to keep it that way long term.
>
> Did this "send out a plan" ever happen?

No. (Not yet?)

>  I am about to rewind 'next'
> and rebuild on top of v2.15, and wondering if I should keep the
> topic or kick it back to 'pu' so that a better justification can be
> given.

Feel free to kick back to 'pu'.

Thanks, Stefan