Re: [PATCH] add test for bug in git-mv with nested submodules
- From
Stefan Beller <sbeller@google.com>
- Date
- Aug 18, 2017, 19:04 UTC
- Message-ID
- <CAGZ79kYNLo_3PfLTOE5wusTs6wgFXZLVH+qNZ-ovxGguhinHLg@mail.gmail.com>
- In-Reply-To
- <20170818160603.GA69414@book.hvoigt.net>
Show 8 quoted lines
> I just copied the shortcut that they were adding themselfes as submodule > in 'setup submodule'. The whole setup of submodules in this test is like > this. This way we already had a nested submodule structure which I could > just add. > > I agree that this is unrealistic so I can change that in the test I am > adding. But from what I have seen, this shortcut is taken in quite some > places when dealing with submodules.
Please do not make it worse. Once upon a time (late '16 IIRC) I had a series floating on the list removing all occurrences, but there were issues with the series and it did not land.