git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] add test for bug in git-mv with nested submodules

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Aug 17, 2017, 10:34 UTC
Message-ID
<20170817103413.GA52233@book.hvoigt.net>

When using git-mv with a submodule it will detect that and update the paths for its configurations (.gitmodules, worktree and gitfile). This does not work for nested submodules where a user renames the root submodule.

We discovered this fact when working on on-demand fetch for renamed submodules. Lets add a test to document.

Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
---
 t/t7001-mv.sh | 9 +++++++++
 1 file changed, 9 insertions(+)
diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh
index e365d1f..39f8aed 100755
--- a/t/t7001-mv.sh
+++ b/t/t7001-mv.sh
@@ -491,4 +491,13 @@ test_expect_success 'moving a submodule in nested directories' '
 	test_cmp actual expect
 '
 
+test_expect_failure 'moving nested submodules' '
+	git commit -am "cleanup commit" &&
+	git submodule add ./. sub_nested &&
+	git commit -m "add sub_nested" &&
+	git submodule update --init --recursive &&
+	git mv sub_nested sub_nested_moved &&
+	git status
+'
+
 test_done
-- 
2.0.0.274.g6b2cd91
Next: Stefan Beller
Message 1 of 8 in “add test for bug in git-mv with nested submodules”
  1. add test for bug in git-mv with nested submodulesHeiko Voigt, Aug 17, 2017
  2. Stefan BellerAug 17, 2017
  3. Heiko VoigtAug 18, 2017
  4. Stefan BellerAug 18, 2017
  5. add test for bug in git-mv for recursive submodulesHeiko Voigt, Sep 15, 2017
  6. Junio C HamanoSep 17, 2017
  7. Stefan BellerSep 18, 2017
  8. Heiko VoigtSep 20, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.