Re: [PATCH 2/3] sha1dc: optionally use sha1collisiondetection as a submodule

From: Stefan Beller <sbeller@google.com>
Date: Jun 6, 2017, 18:48 UTC
Message-ID: <CAGZ79kYGaF6=RQZ2HpTZ8qE50V2SU0DO+-0nx-n9WEkQmM4WoA@mail.gmail.com>
In-Reply-To: <20170606151231.25172-3-avarab@gmail.com>

On Tue, Jun 6, 2017 at 8:12 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 9 quoted lines

> Add an option to use the sha1collisiondetection library from the
> submodule in sha1collisiondetection/ instead of in the copy in the
> sha1dc/ directory.
>
> This allows us to try out the submodule in sha1collisiondetection
> without breaking the build for anyone who's not expecting them as we
> work out any kinks.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Other projects using submodules sometimes have a .gitattributes entry to have .gitmodules not exported via git-archive. Do we want a similar thing?

Speaking of attributes, I wonder if we want to specify
the .gitmodules file to be text with unixy file endings:
Having an entry
    .gitattributes eol=crlf
to simulate a Windows environment doesn't harm
submodule operation, which is good. I'll check if we
have a test for that.