Re: Git v2.13.1 SHA1 very broken

From: Adam Dinwoodie <adam@dinwoodie.org>
Date: Jun 6, 2017, 12:43 UTC
Message-ID: <20170606124323.GD25777@dinwoodie.org>
In-Reply-To: <xmqqmv9l8h5z.fsf@gitster.mtv.corp.google.com>

On Tue, Jun 06, 2017 at 08:55:04PM +0900, Junio C Hamano wrote:

Show 12 quoted lines

> Adam Dinwoodie <adam@dinwoodie.org> writes:
> 
> > Digging briefly into the endianness detection, it appears Cygwin has
> > both _LITTLE_ENDIAN and _BIG_ENDIAN defined.  Git's detection works by
> > assuming it's in a little endian environment and switching to big endian
> > if it detects any of the defines that indicate such, and a010391 adds
> > _BIG_ENDIAN to the set of defines that indicate big endianness.
> 
> I suspect that the upstream has already fixed this one to cope with
> FreeBSD.  My preference is that we do another import on top of the
> ab/sha1dc-maint topic, below the commit on ab/sha1dc that adds the
> upstream as a submodule.

Apparently so! a010391 brings Git up to the upstream's cc46554 ("Skip temporary variable for SHA1DC_ALLOW_UNSIGNED_ACCESS", 2017-05-18); the problem has been fixed in upstream's a24eef5 ("rewrote Endianness selection", 2017-05-29).

In the interim, I'll use the CFLAGS route to try to get a v2.13.1 build ready to release for Cygwin.