git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list

From
Stefan Beller <sbeller@google.com>
Date
Apr 5, 2017, 20:00 UTC
Message-ID
<CAGZ79kYFjuESBr72f5eyv7r4XohzY4KoQU36pqHLa3CsLuKi9w@mail.gmail.com>
In-Reply-To
<20170405195600.54801-2-git@jeffhostetler.com>
On Wed, Apr 5, 2017 at 12:55 PM,  <git@jeffhostetler.com> wrote:
> +       if (list->nr + 1 >= list->alloc)
> +               ALLOC_GROW(list->items, list->nr+1, list->alloc);
No need for the condition here as it is part of the macro as well.

Thanks for spotting this fix! Stefan

Previous: git@jeffhostetler.comNext: Jeff King
Message 3 of 10 in “string-list: use ALLOC_GROW macro when reallocing”
  1. 0/2 string-list: use ALLOC_GROW macro when reallocinggit@jeffhostetler.com, Apr 5, 2017
  2. 1/2 string-list: use ALLOC_GROW macro when reallocing string_listgit@jeffhostetler.com, Apr 5, 2017
  3. Stefan BellerApr 5, 2017
  4. Jeff KingApr 5, 2017
  5. Jeff HostetlerApr 5, 2017
  6. Jonathan NiederApr 5, 2017
  7. 2/2 p0005-status: time status on very large repogit@jeffhostetler.com, Apr 5, 2017
  8. Jonathan NiederApr 5, 2017
  9. Jeff HostetlerApr 6, 2017
  10. Jeff KingApr 7, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.