Re: [PATCH v1 2/2] p0005-status: time status on very large repo

From: Jeff King <peff@peff.net>
Date: Apr 7, 2017, 04:29 UTC
Message-ID: <20170407042955.i63i6prc3rwi4i6s@sigill.intra.peff.net>
In-Reply-To: <db545f25-b0a7-2359-e6f5-7a89860c4022@jeffhostetler.com>

On Thu, Apr 06, 2017 at 09:26:15AM -0400, Jeff Hostetler wrote:

Show 13 quoted lines

> > > +export depth
> > > +export width
> > > +export files
> > 
> > Why are these exported?  test_expect_success code (unlike test_per
> > code) runs in the same shell as outside, so it doesn't seem necessary.
> 
> I'm still trying to grok all of the shell wizardry hidden
> in the test_* functions, so some may be novice mistakes here.
> However, I couldn't get some of the steps to run in an earlier
> draft of it without them.  But I copied this from p0004-read-tree
> that I posted in an earlier patch and this version is much simpler
> so they may not be necessary here.  I'll double check.

It's a subtle but annoying difference between the regular tests and the perf tests. test_perf() runs in a subshell because of the way the timing is implemented. There are a few pointers in t/perf/README regarding this.

-Peff