git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] WAS: [PATCH] mv: allow moving nested submodules

From
Stefan Beller <sbeller@google.com>
Date
Apr 19, 2016, 16:56 UTC
Message-ID
<CAGZ79kYEjRSpet-5EQibJJ-57EkefQZm+zZr-d1K8Y9-=-fAmQ@mail.gmail.com>
In-Reply-To
<xmqqwpnu31qu.fsf@gitster.mtv.corp.google.com>
On Mon, Apr 18, 2016 at 5:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Stefan Beller <sbeller@google.com> writes:
>
>> A single patch evolves into a series.
>
> Power of code inspection to see bugs that are not reported, perhaps
> ;-)?
>
> I wonder if we can come up with test cases to cover these potential
> issues that are addressed in [1/2]?

I think we can do a chmod a-w on the .git file and then updating that file fails. (renaming is fine, but putting the new, possibly different link to the git dir in there fails.)

I do not quite know what we'd expect from a "git mv -k" on that. It is documented as "skip move/rename errors", so maybe we need to undo the rename to actually skip it once an error occurs?

That said I think I know how to write a test for that, but I am unsure if patch 1 is a good idea.

Thanks, Stefan

>
> Thanks.
>
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 7 in “WAS: [PATCH] mv: allow moving nested submodules”
  1. 0/2 WAS: [PATCH] mv: allow moving nested submodulesStefan Beller, Apr 18, 2016
  2. 1/2 mv submodule: respect ignore_errors for errors in submodule codeStefan Beller, Apr 18, 2016
  3. 2/2 mv: allow moving nested submodulesStefan Beller, Apr 18, 2016
  4. Jacob KellerApr 19, 2016
  5. Junio C HamanoApr 19, 2016
  6. Stefan BellerApr 19, 2016
  7. Junio C HamanoApr 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.