From: Stefan Beller <sbeller@google.com>
Date: Tue, 19 Apr 2016 16:56:07 GMT
Subject: Re: [PATCH 0/2] WAS: [PATCH] mv: allow moving nested submodules
Message-ID: <CAGZ79kYEjRSpet-5EQibJJ-57EkefQZm+zZr-d1K8Y9-=-fAmQ@mail.gmail.com>
In-Reply-To: <xmqqwpnu31qu.fsf@gitster.mtv.corp.google.com>

On Mon, Apr 18, 2016 at 5:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Stefan Beller <sbeller@google.com> writes:
>
>> A single patch evolves into a series.
>
> Power of code inspection to see bugs that are not reported, perhaps
> ;-)?
>
> I wonder if we can come up with test cases to cover these potential
> issues that are addressed in [1/2]?

I think we can do a chmod a-w on the .git file and then updating that file
fails. (renaming is fine, but putting the new, possibly different link
to the git dir
in there fails.)

I do not quite know what we'd expect from a "git mv -k" on that.
It is documented as "skip move/rename errors", so maybe we need
to undo the rename to actually skip it once an error occurs?

That said I think I know how to write a test for that, but I am unsure
if patch 1 is a good idea.

Thanks,
Stefan


>
> Thanks.
>