Re: [PATCH 0/3] Another approach to large transactions
- From
Stefan Beller <sbeller@google.com>
- Date
- Apr 17, 2015, 23:31 UTC
- Message-ID
- <CAGZ79kYEbnZvgdhjPvc2rR7QKp-CjUB3Ytqsp8JK2QBqzuUowA@mail.gmail.com>
- In-Reply-To
- <CAGZ79kZvE+YJeKCYXN-RD3MFmP17VkqW8WUUssk6UgK_38iWrg@mail.gmail.com>
On Fri, Apr 17, 2015 at 3:17 PM, Stefan Beller <sbeller@google.com> wrote:
Show 9 quoted lines
> On Fri, Apr 17, 2015 at 3:12 PM, Junio C Hamano <gitster@pobox.com> wrote: >> >> This is now pushed out and sitting at the tip of 'pu'. It seems to >> break one of the tests in 1400 when merged to 'next', but I didn't >> look it closely. >> >> Thanks. > > ok, I'll look more closely.
Apparently I screwed up even before sending the patches over the wire.
not ok 144 - large transaction deleting branches does not burst open file limit
fails in my local branch as well as origin/pu as well on origin/sb/remove-fd-from-ref-lock
So there is a pretty strong argument, the code is only improving large transaction creating branches and not deleting branches.