Re: What's cooking in git.git (Nov 2016, #04; Mon, 21)

From: Stefan Beller <sbeller@google.com>
Date: Nov 21, 2016, 23:19 UTC
Message-ID: <CAGZ79kY8AUwOYAQX=PEHU3H+AhLAuxtC9+hb42da6TrSdz4BzA@mail.gmail.com>
In-Reply-To: <xmqqh970h1da.fsf@gitster.mtv.corp.google.com>

On Mon, Nov 21, 2016 at 3:14 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

>>
>> I did review both off and on list and I think the latest version is good.
>
> I thought that there were strange mixups of two enumeration types
> that are incompatible, at least.  Is there an update that I didn't
> see, or you didn't read problems pointed out on list?

Oh right; there was no resolution to that one IIRC.

>
>>> * jt/use-trailer-api-in-commands (2016-11-02) 6 commits

..

Show 5 quoted lines

>> From a cursory read (with the SQUASH applied)
>> this seems to be done to me.
>
> We are not all that in a hurry to move non-fix to 'next' only with a
> cursory read at this point in the cycle ;-).

But the cycle only applies to patches going to master, but when asking for doneness I assumed you were asking for opinions on the transition pu -> next, which I would support.

Thanks, Stefan