Re: [GSoC][PATCH v5 2/3] t7407: test "submodule foreach --recursive" from subdirectory added

From: Stefan Beller <sbeller@google.com>
Date: May 26, 2017, 16:19 UTC
Message-ID: <CAGZ79kY4s_WtEJfyFStchFvr7ka659zYjv6H3vy9GsCX2sKbdg@mail.gmail.com>
In-Reply-To: <20170526151713.10974-2-pc44800@gmail.com>

On Fri, May 26, 2017 at 8:17 AM, Prathamesh Chavan <pc44800@gmail.com> wrote:

> Additional test cases added to the submodule-foreach test suite
> to check the submodule foreach --recursive behavior from a
> subdirectory as this was missing from the test suite.

As this demonstrates the fixture of the first patch, this could be squashed into the first commit.

Reason: When someone is looking at that first commit, they
may wonder if there is no test that demonstrates the fix. (as fixing
a bug with no test is bad style. ;) And given the data structures of
Git it is only easy to find the previous commit, but hard to find the
next commit (this one) later on.

I think with only the minor nit in patch 3, the foreach is tackled. :)

Thanks, Stefan