[GSoC][PATCH v6 1/2] submodule: fix buggy $path and $sm_path variable's value
- From
Prathamesh Chavan <pc44800@gmail.com>
- Date
- Jun 2, 2017, 11:24 UTC
- Message-ID
- <20170602112428.11131-1-pc44800@gmail.com>
- In-Reply-To
- <48149a4a-c7e3-d70e-7894-369681587372@ramsayjones.plus.com>
According to the documentation about git-submodule foreach subcommand's $path variable: $path is the name of the submodule directory relative to the superproject
But it was observed when the value of the $path value deviates from this for the nested submodules when the <command> is run from a subdirectory. This patch aims for its correction.
Additional test cases added to the submodule-foreach test suite in t7407, to check the submodule foreach --recursive behavior from a subdirectory as this was missing from the test suite.
Helped-by: Brandon Williams <bmwill@google.com> Mentored-by: Christian Couder <christian.couder@gmail.com> Mentored-by: Stefan Beller <sbeller@google.com> Signed-off-by: Prathamesh Chavan <pc44800@gmail.com> --- git-submodule.sh | 2 +- t/t7407-submodule-foreach.sh | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-)
diff --git a/git-submodule.sh b/git-submodule.sh index c0d0e9a4c..ea6f56337 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -344,9 +344,9 @@ cmd_foreach() prefix="$prefix$sm_path/" sanitize_submodule_env cd "$sm_path" && - sm_path=$(git submodule--helper relative-path "$sm_path" "$wt_prefix") && # we make $path available to scripts ... path=$sm_path && + sm_path=$displaypath && if test $# -eq 1 then eval "$1" diff --git a/t/t7407-submodule-foreach.sh b/t/t7407-submodule-foreach.sh index 6ba5daf42..f4e07eee3 100755 --- a/t/t7407-submodule-foreach.sh +++ b/t/t7407-submodule-foreach.sh @@ -197,6 +197,39 @@ test_expect_success 'test messages from "foreach --recursive" from subdirectory' test_i18ncmp expect actual ' +sub1sha1=$(cd clone2/sub1 && git rev-parse HEAD) +sub2sha1=$(cd clone2/sub2 && git rev-parse HEAD) +sub3sha1=$(cd clone2/sub3 && git rev-parse HEAD) +nested1sha1=$(cd clone2/nested1 && git rev-parse HEAD) +nested2sha1=$(cd clone2/nested1/nested2 && git rev-parse HEAD) +nested3sha1=$(cd clone2/nested1/nested2/nested3 && git rev-parse HEAD) +submodulesha1=$(cd clone2/nested1/nested2/nested3/submodule && git rev-parse HEAD) + +cat >expect <<EOF +Entering '../nested1' +$pwd/clone2-nested1-../nested1-$nested1sha1 +Entering '../nested1/nested2' +$pwd/clone2/nested1-nested2-../nested1/nested2-$nested2sha1 +Entering '../nested1/nested2/nested3' +$pwd/clone2/nested1/nested2-nested3-../nested1/nested2/nested3-$nested3sha1 +Entering '../nested1/nested2/nested3/submodule' +$pwd/clone2/nested1/nested2/nested3-submodule-../nested1/nested2/nested3/submodule-$submodulesha1 +Entering '../sub1' +$pwd/clone2-foo1-../sub1-$sub1sha1 +Entering '../sub2' +$pwd/clone2-foo2-../sub2-$sub2sha1 +Entering '../sub3' +$pwd/clone2-foo3-../sub3-$sub3sha1 +EOF + +test_expect_success 'test "submodule foreach --recursive" from subdirectory' ' + ( + cd clone2/untracked && + git submodule foreach --recursive "echo \$toplevel-\$name-\$sm_path-\$sha1" >../../actual + ) && + test_i18ncmp expect actual +' + cat > expect <<EOF nested1-nested1 nested2-nested2
-- 2.13.0