Re: [GSoC PATCH v4 2/7] list-objects-filter: add list_objects_filter__filter_oidset()

From: Siddharth Shrimali <r.siddharth.shrimali@gmail.com>
Date: Aug 12, 2026, 19:22 UTC
Message-ID: <CAGWgyh9bJ=BSq1B8LSEaQth_4fQHB_YHDgHmf5m5MYcENAkxrw@mail.gmail.com>
In-Reply-To: <xmqq1pc3xlju.fsf@gitster.g>

On Wed, 12 Aug 2026 at 23:34, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Here "struct object_info" is defined as
>
>         struct object_info {
>                 /* The object type. */
>                 enum object_type *typep;
>
>                 /* The inflated object size in bytes. */
>                 size_t *sizep;
>                 ...
>
> but local "size" whose address is assigned to is of type "unsigned
> long".

Oh right, thanks for catching it! I used "unsigned long" because that is the type the older object-size interfaces use(odb_read_object()), so I copied that pattern without noticing that object_info.sizep is "size_t *".

I will change the local to "size_t" in v5 so it matches sizep.

Thanks, Siddharth Shrimali