Re: [PATCH] remote-curl: avoid hang if curl asks for more data after eof
- From
Jiří Hruška <jirka@fud.cz>
- Date
- Nov 27, 2023, 13:19 UTC
- Message-ID
- <CAGE_+C5u9H8m5faK1vXKk6QTyjcHgKHqxOZy5ptzsYbF_0yrCQ@mail.gmail.com>
- In-Reply-To
- <CAGE_+C7h6HOh+ptdhwJ3MNn5HWFoc1WF-foLRrew6FJEo_yupg@mail.gmail.com>
I have discussed this with Daniel Stenberg himself in this thread: https://curl.se/mail/lib-2023-11/0017.html
The summary is:
- It was never intended/expected that CURLOPT_READFUNCTION would be called more after already returning EOF once. libcurl has been modified to never do this anymore (in master, to be released in what comes after 8.4.0).
- The problem has been tracked down to a particular case that could reproduce only if using HTTP/2 and only in cURL versions 7.84.0 – 8.1.2 (inclusive, roughly between June 2022 and July 2023). The same misbehavior is still technically possible in newer versions, but not happening in practice.
Therefore, I believe nothing strongly _needs_ to be done on the Git side.