git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/5] Avoid hang if curl needs eof twice + minor related improvements

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Nov 27, 2023, 18:26 UTC
Message-ID
<20231127182618.212901-1-jonathantanmy@google.com>
In-Reply-To
<CAGE_+C4B=zjPqNV+fGt9gaA0O8qmqmK3CDh-eLBPmXx+ChzXAQ@mail.gmail.com>
Jiří Hruška <jirka@fud.cz> writes:
Show 11 quoted lines
> > I've already reviewed 1/5 so I'll summarize what I think of the rest.
> Thank you for your time looking at everything, Jonathan.
> 
> I'm sorry for the delay in my reply, I was away for a while and also trying
> to get clarity from the cURL side, summarized in [1].
> 
> [1] https://lore.kernel.org/git/CAGE_+C5u9H8m5faK1vXKk6QTyjcHgKHqxOZy5ptzsYbF_0yrCQ@mail.gmail.com/
> 
> Most importantly, the bug has been apparently in libcurl only for ~1 year and
> it can no longer manifest for a few months. Therefore, the main point of my
> changes is a bit moot and we might reconsider what is useful and what is not.

Thanks for following up with the Curl side. Even if the Curl bug is fixed now, for what it's worth, I still think that it's worth including this mitigation in Git.

Previous: Jiří HruškaNext: Jiří Hruška
Message 10 of 18 in “remote-curl: avoid hang if curl asks for more data after eof”
  1. remote-curl: avoid hang if curl asks for more data after eofJiří Hruška, Nov 13, 2023
  2. Jonathan TanNov 13, 2023
  3. Junio C HamanoNov 14, 2023
  4. Jiří HruškaNov 14, 2023
  5. Jiří HruškaNov 27, 2023
  6. Jiří HruškaNov 14, 2023
  7. 0/5 Avoid hang if curl needs eof twice + minor related improvementsJiří Hruška, Nov 15, 2023
  8. Jonathan TanNov 15, 2023
  9. Jiří HruškaNov 27, 2023
  10. Jonathan TanNov 27, 2023
  11. 2/5 remote-curl: improve readability of curl callbacksJiří Hruška, Nov 15, 2023
  12. 1/5 remote-curl: avoid hang if curl asks for more data after eofJiří Hruška, Nov 15, 2023
  13. Jonathan TanNov 15, 2023
  14. 3/5 remote-curl: simplify rpc_out() - remove superfluous ifsJiří Hruška, Nov 15, 2023
  15. 4/5 remote-curl: simplify rpc_out() - less nesting and renameJiří Hruška, Nov 15, 2023
  16. 5/5 http: reset CURLOPT_POSTFIELDSIZE_LARGE between requestsJiří Hruška, Nov 15, 2023
  17. Patrick SteinhardtNov 15, 2023
  18. Jiří HruškaNov 27, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.