Re: [RFC PATCH 0/1] Implement CMake build

From: Isaac Hier <isaachier@gmail.com>
Date: Jan 24, 2018, 13:45 UTC
Message-ID: <CAG6xkCZn6m2n0rDvpN6MmZcOr2hJBRCfhrppC37f-DUj3_JZsw@mail.gmail.com>
In-Reply-To: <20180123001648.24260-1-isaachier@gmail.com>

I realize this is a huge patch, but does anyone have feedback for the general idea?

On Mon, Jan 22, 2018 at 7:16 PM, Isaac Hier <isaachier@gmail.com> wrote:

Show 43 quoted lines

> This patch adds a mostly complete (aside from building tests, documentation,
> installation, etc.) CMake build to the git project. I am not sure how much
> interest there is in a CMake build, so please send me feedback one way or
> another. Personally, I believe CMake will help with Windows builds and is
> somewhat easier to read than a Makefile. I considered, adding this to the
> contrib directory, but CMakeLists.txt almost always reside in the original
> directories, and I'm not sure how wise it would be to do otherwise. If you are
> interested in a CMake build, I would be more than happy to finish up the work
> here. Decided to wait until I discussed the issue here to finish the final parts
> of the build.
>
> Isaac Hier (1):
>   Implement CMake build
>
>  CMakeLists.txt              | 1849 +++++++++++++++++++++++++++++++++++++++++++
>  cmake/GenerateCmdlist.cmake |   83 ++
>  cmake/fopen_dir_test.c      |   11 +
>  cmake/fstat_test.c          |   37 +
>  cmake/gmtime_test.c         |    7 +
>  cmake/iconv_test.c          |   13 +
>  cmake/inline_test.c         |    9 +
>  cmake/mkdir_test.c          |    7 +
>  cmake/mmap_test.c           |   35 +
>  cmake/parens_test.c         |    6 +
>  cmake/snprintf_test.c       |    7 +
>  cmake/sysctl_test.c         |   11 +
>  12 files changed, 2075 insertions(+)
>  create mode 100644 CMakeLists.txt
>  create mode 100644 cmake/GenerateCmdlist.cmake
>  create mode 100644 cmake/fopen_dir_test.c
>  create mode 100644 cmake/fstat_test.c
>  create mode 100644 cmake/gmtime_test.c
>  create mode 100644 cmake/iconv_test.c
>  create mode 100644 cmake/inline_test.c
>  create mode 100644 cmake/mkdir_test.c
>  create mode 100644 cmake/mmap_test.c
>  create mode 100644 cmake/parens_test.c
>  create mode 100644 cmake/snprintf_test.c
>  create mode 100644 cmake/sysctl_test.c
>
> --
> 2.14.1
>