Re: [RFC PATCH 0/1] Implement CMake build
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Jan 24, 2018, 18:11 UTC
- Message-ID
- <CA+P7+xq2eucumKT1VRymvnwv0KoauiYsmko-s=UAChoQ3X3w1g@mail.gmail.com>
- In-Reply-To
- <CAG6xkCZn6m2n0rDvpN6MmZcOr2hJBRCfhrppC37f-DUj3_JZsw@mail.gmail.com>
On Wed, Jan 24, 2018 at 5:45 AM, Isaac Hier <isaachier@gmail.com> wrote:
> I realize this is a huge patch, but does anyone have feedback for the > general idea? >
I don't know anything about CMake so I can't comment on the patch itself. Having additional build systems does not bother me, but it does mean that someone has to maintain the build system and try to keep it in sync with changes that occur to the main one in use. That can be problematic.
Personally, if we added a new build system, I think I'd prefer something like meson with ninja, but that's only because of the examples I've seen where build times were improved significantly. I have no idea what advantages CMake would give on this front.
Thanks, Jake