Re: [RFC PATCH 1/1] maintenance: separate parallelism safe and unsafe tasks

From: Calvin Wan <calvinwan@google.com>
Date: Nov 11, 2024, 18:12 UTC
Message-ID: <CAFySSZC_rqGSXLZBQ78zTQ4Mt0+8Cs0OwmfwzKNvyiKoOQRX+g@mail.gmail.com>
In-Reply-To: <xmqqv7wub08c.fsf@gitster.g>

On Mon, Nov 11, 2024 at 1:15 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

>
> So if the caller wants to eventually run both, it has to spawn this
> program twice, the first time with one option and the second time
> with the other option?  Somehow it feels a bit unsatisfying.  If the
> caller says "I want to run both classes", and if your safe/unsafe
> classification system knows which task belongs to which class and
> the classification system that unsafe ones should be run before safe
> ones (or whatever), wouldn't it be easier to use for the caller to
> be able to say "run both", and let your classification system take
> care of the ordering?

Yes this felt unsatisfactory to me as well for now. The issue is that, when invoked from maintenance, whether gc is detached or not is dependent on maintenance being detached or not. That is why in the commit message of the first patch, I left a "WIP: automatically run gc unsafe tasks when gc is invoked but not from maintenance". When I turn this into v1, however, I do intend on making this satisfactory.