git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [tig] [PATCHv2 0/3] log: colour the diffstat

From
Jonas Fonseca <jonas.fonseca@gmail.com>
Date
Apr 17, 2014, 00:52 UTC
Message-ID
<CAFuPQ1L=iW+kWXZ41BDKXzyMH0Ci87_qi79FCm14juiK=Qfh=A@mail.gmail.com>
In-Reply-To
<1397426068-17439-1-git-send-email-a.kumar@alumni.iitm.ac.in>
Hi Kumar,

On Sun, Apr 13, 2014 at 5:54 PM, Kumar Appaiah <a.kumar@alumni.iitm.ac.in> wrote:

>
> These patches add colourization to the log view. They reuse the diff
> stat drawing functions from the diff module directly.

This is a great idea. I wonder though if it would make sense to put this into the pager backend instead so all pager based views can benefit unless of course the "state machine" would end up becoming too complicated.

> This version just includes some code reformatting and minor
> fixes. Please comment on what other fixes could help.

See my other email regarding fixes. Since I am currently refactoring how views are drawn I'd prefer to postpone merging this patchset until the dust has settled. I'll try to rebase the patches once I get there before reaching out to you.

-- 
Jonas Fonseca
Previous: Kumar Appaiah
Message 11 of 11 in “log: colour the diffstat.”
  1. Kumar AppaiahApr 11, 2014
  2. [tig] [PATCH 1/3] diff: Move diff stat addition to a common functionKumar Appaiah, Apr 11, 2014
  3. [tig] [PATCH 2/3] diff: Move diff stat drawing to a common functionKumar Appaiah, Apr 11, 2014
  4. [tig] [PATCH 3/3] log: Colour the diff statKumar Appaiah, Apr 11, 2014
  5. [tig] [PATCHv2 0/3] log: colour the diffstatKumar Appaiah, Apr 13, 2014
  6. [tig] [PATCHv2 1/3] diff: Move diff stat addition to a common functionKumar Appaiah, Apr 13, 2014
  7. [tig] [PATCHv2 2/3] diff: Move diff stat drawing to a common functionKumar Appaiah, Apr 13, 2014
  8. [tig] [PATCHv2 3/3] log: Colour the diff statKumar Appaiah, Apr 13, 2014
  9. Jonas FonsecaApr 17, 2014
  10. Kumar AppaiahApr 17, 2014
  11. Jonas FonsecaApr 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.