Re: [tig] [PATCHv2 3/3] log: Colour the diff stat

From: Kumar Appaiah <a.kumar@alumni.iitm.ac.in>
Date: Apr 17, 2014, 01:04 UTC
Message-ID: <20140417010454.GA27665@odessa>
In-Reply-To: <CAFuPQ1JbpNcun3hGps=hwaM14wOjF+iU9bsm9+ZmJvJV_Fea4Q@mail.gmail.com>

On Wed, Apr 16, 2014 at 08:44:41PM -0400, Jonas Fonseca wrote:

Show 9 quoted lines

> On Sun, Apr 13, 2014 at 5:54 PM, Kumar Appaiah
> <a.kumar@alumni.iitm.ac.in> wrote:
> >
> > This commit adds custom log_read and log_draw functions that utilize
> > the diff stat drawing functions from the diff module. The absence of
> > the triple hyphen separator prevents direct usage of the diff drawing
> > functions directly.
> 
> See my comments below.

Hi Jonas.

Show 8 quoted lines

> > +static bool
> > +log_draw(struct view *view, struct line *line, unsigned int lineno)
> > +{
> > +       char *text = line->data;
> > +       enum line_type type = line->type;
> > +
> 
> This is missing a call to draw_lineno(...)

Noted.

Show 5 quoted lines

> > +       if (type == LINE_DIFF_STAT) {
> > +               diff_common_draw_diff_stat(view, &type, &text);
> > +               draw_text(view, type, text);
> 
> I had to #include "tig/draw.h" for this to compile.

I'll take care of this.

I'll send you a pull request eventually. You can handle it after your refactor is complete.

Thanks!

Kumar

-- 
Kumar Appaiah