Re: [PATCH v3] parse-remote: remove reference to unused op_prep
- From
Pranit Bauva <pranit.bauva@gmail.com>
- Date
- Feb 4, 2017, 21:15 UTC
- Message-ID
- <CAFZEwPOdL4mOAnmTUqs5LmfdG2GQCieVGVQ7T3ZWR0n+d6tCQQ@mail.gmail.com>
- In-Reply-To
- <1486218663-31820-1-git-send-email-kannan.siddharth12@gmail.com>
Hey Siddharth,
On Sat, Feb 4, 2017 at 8:01 PM, Siddharth Kannan <kannan.siddharth12@gmail.com> wrote:
Show 7 quoted lines
> The error_on_missing_default_upstream helper function learned to
> take op_prep argument with 15a147e618 ("rebase: use @{upstream}
> if no upstream specified", 2011-02-09), but as of 045fac5845
> ("i18n: git-parse-remote.sh: mark strings for translation",
> 2016-04-19), the argument is no longer used. Remove it.
>
> Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com>This looks good to me! Thanks :)
Regards, Pranit Bauva