Re: [PATCH v3] parse-remote: remove reference to unused op_prep

From: Siddharth Kannan <kannan.siddharth12@gmail.com>
Date: Feb 6, 2017, 02:28 UTC
Message-ID: <20170206022804.GB3323@ubuntu-512mb-blr1-01.localdomain>
In-Reply-To: <CAFZEwPOdL4mOAnmTUqs5LmfdG2GQCieVGVQ7T3ZWR0n+d6tCQQ@mail.gmail.com>

Hey Pranit, On Sun, Feb 05, 2017 at 02:45:46AM +0530, Pranit Bauva wrote:

Show 16 quoted lines

> Hey Siddharth,
> 
> On Sat, Feb 4, 2017 at 8:01 PM, Siddharth Kannan
> <kannan.siddharth12@gmail.com> wrote:
> > The error_on_missing_default_upstream helper function learned to
> > take op_prep argument with 15a147e618 ("rebase: use @{upstream}
> > if no upstream specified", 2011-02-09), but as of 045fac5845
> > ("i18n: git-parse-remote.sh: mark strings for translation",
> >  2016-04-19), the argument is no longer used.  Remove it.
> >
> > Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com>
> 
> This looks good to me! Thanks :)
> 
> Regards,
> Pranit Bauva

Should I send this patch with "To:" set to Junio and "Cc:" set to the mailing list, as mentioend in the SubmittingPatches document?

- Siddharth Kannan