git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sha1-name.c: for ":/", find detached HEAD commits

From
William Chargin <wchargin@gmail.com>
Date
Jul 11, 2018, 17:49 UTC
Message-ID
<CAFW+GMD62V=o4hoEYKVteBZHzqBtquzLzTv2WXiSPZf3ZhOpeg@mail.gmail.com>
In-Reply-To
<CACsJy8AMwKHUyUe-4-MKLn1D3x-+iiFW-Wdjj+HeX_JZ=MkO+w@mail.gmail.com>
> > Does for_each_ref() iterate over per-worktree refs (like "bisect",
> > perhaps)?
>
> No.

To be clear: it iterates only over the per-worktree refs for the current worktree. So, if you mark an unreachable commit as "bad" with bisect, then that commit is reachable (and found by ":/") in the enclosing worktree only.

With this patch, ":/" now behaves the same way with HEADs, which makes sense to me. Agreed with the above discussion.

I can add a test for this.
Previous: Duy NguyenNext: William Chargin
Message 11 of 19 in “sha1-name.c: for ":/", find detached HEAD commits”
  1. sha1-name.c: for ":/", find detached HEAD commitsWilliam Chargin, Jul 10, 2018
  2. Jeff KingJul 10, 2018
  3. Junio C HamanoJul 10, 2018
  4. William CharginJul 11, 2018
  5. Jeff KingJul 11, 2018
  6. Junio C HamanoJul 11, 2018
  7. Duy NguyenJul 11, 2018
  8. Jeff KingJul 11, 2018
  9. Junio C HamanoJul 11, 2018
  10. Duy NguyenJul 11, 2018
  11. William CharginJul 11, 2018
  12. sha1-name.c: for ":/", find detached HEAD commitsWilliam Chargin, Jul 12, 2018
  13. Jeff KingJul 12, 2018
  14. Junio C HamanoJul 12, 2018
  15. William CharginJul 12, 2018
  16. Junio C HamanoJul 12, 2018
  17. William CharginJul 12, 2018
  18. Jeff KingJul 13, 2018
  19. William CharginJul 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.