git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] sha1-name.c: for ":/", find detached HEAD commits

From
Jeff King <peff@peff.net>
Date
Jul 13, 2018, 19:24 UTC
Message-ID
<20180713192441.GA10354@sigill.intra.peff.net>
In-Reply-To
<CAFW+GMByLBbj6oDu-ERhN-bFO__Tj_M752-OYLYa7=z5DF0Ckg@mail.gmail.com>
On Thu, Jul 12, 2018 at 01:01:23PM -0700, William Chargin wrote:
> Contents look good to me. I don't understand why the file name in your
> patch is sha1_name.c as opposed to sha1-name.c (I see e5e5e0883 from
> 2018-04-10, but that sounds pretty old), but I trust that whatever
> you're doing there is correct.

Junio typically applies bugfixes as close to the bug-source as possible, which allows them to be merged-up into various releases (rather than cherry-picked, which would be required if built on top of 'master').

Ideally this is directly on top of the commit that introduced the bug, though for an ancient bug like this, it's not worth the effort. It looks like he applied it on the 2.16 maint branch, which predates e5e5e0883. When it's merged up, the resolution will handle the rename (probably even automatically due to Git's rename detection).

> > Thanks for working on this.
> 
> You're quite welcome. Thanks to you, Peff, and Duy for your help. This
> was a pleasant experience for me as a new contributor. :-)
Great. Please come back anytime. :)
-Peff
Previous: William CharginNext: William Chargin
Message 18 of 19 in “sha1-name.c: for ":/", find detached HEAD commits”
  1. sha1-name.c: for ":/", find detached HEAD commitsWilliam Chargin, Jul 10, 2018
  2. Jeff KingJul 10, 2018
  3. Junio C HamanoJul 10, 2018
  4. William CharginJul 11, 2018
  5. Jeff KingJul 11, 2018
  6. Junio C HamanoJul 11, 2018
  7. Duy NguyenJul 11, 2018
  8. Jeff KingJul 11, 2018
  9. Junio C HamanoJul 11, 2018
  10. Duy NguyenJul 11, 2018
  11. William CharginJul 11, 2018
  12. sha1-name.c: for ":/", find detached HEAD commitsWilliam Chargin, Jul 12, 2018
  13. Jeff KingJul 12, 2018
  14. Junio C HamanoJul 12, 2018
  15. William CharginJul 12, 2018
  16. Junio C HamanoJul 12, 2018
  17. William CharginJul 12, 2018
  18. Jeff KingJul 13, 2018
  19. William CharginJul 13, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.