git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] Move documentation of string_list into string-list.h

From
Han-Wen Nienhuys <hanwen@google.com>
Date
Sep 26, 2017, 11:22 UTC
Message-ID
<CAFQ2z_PhSus5yBvG0FV+8DRHbR+OAzFB74sodfEN7YvPjhb3XQ@mail.gmail.com>
In-Reply-To
<xmqqefquavam.fsf@gitster.mtv.corp.google.com>
On Tue, Sep 26, 2017 at 7:22 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 9 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>>
>> Thanks.  I am not sure if you can safely reorder the contents of the
>> header files in general, but I trust that you made sure that this
>> does not introduce problems (e.g. referrals before definition).
>
> Alas, this time it seems my trust was grossly misplaced.  Discarding
> this patch and redoing the integration cycle for the day.
Oops, my bad.
I resent the remaining patches. They do compile now :)
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Previous: Junio C Hamano
Message 14 of 14 in “Assorted comment fixes”
  1. 0/4 Assorted comment fixesHan-Wen Nienhuys, Sep 25, 2017
  2. 1/4 Fix typo in submodule.hHan-Wen Nienhuys, Sep 25, 2017
  3. 3/4 Document submodule_to_gitdirHan-Wen Nienhuys, Sep 25, 2017
  4. Brandon WilliamsSep 25, 2017
  5. 2/4 Clarify return value ownership of real_path and read_gitfile_gentlyHan-Wen Nienhuys, Sep 25, 2017
  6. Brandon WilliamsSep 25, 2017
  7. Junio C HamanoSep 26, 2017
  8. 4/4 Move documentation of string_list into string-list.hHan-Wen Nienhuys, Sep 25, 2017
  9. Brandon WilliamsSep 25, 2017
  10. Stefan BellerSep 25, 2017
  11. Andrey RybakSep 27, 2017
  12. Junio C HamanoSep 26, 2017
  13. Junio C HamanoSep 26, 2017
  14. Han-Wen NienhuysSep 26, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.