git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] Document submodule_to_gitdir

From
BWBrandon Williams <bmwill@google.com>
Date
Sep 25, 2017, 17:25 UTC
Message-ID
<20170925172524.GC35385@google.com>
In-Reply-To
<20170925155927.32328-4-hanwen@google.com>
On 09/25, Han-Wen Nienhuys wrote:
Show 16 quoted lines
> Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
> ---
>  submodule.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/submodule.c b/submodule.c
> index b12600fc7..b66c23f5d 100644
> --- a/submodule.c
> +++ b/submodule.c
> @@ -1997,6 +1997,9 @@ const char *get_superproject_working_tree(void)
>  	return ret;
>  }
>  
> +/* Put the gitdir for a submodule (given relative to the main repository worktree)
> + * into `buf`, or return -1 on error.
> + */
Same nit as in patch [2/4]
Show 6 quoted lines
>  int submodule_to_gitdir(struct strbuf *buf, const char *submodule)
>  {
>  	const struct submodule *sub;
> -- 
> 2.14.1.821.g8fa685d3b7-goog
> 
-- 
Brandon Williams
Previous: Han-Wen NienhuysNext: Han-Wen Nienhuys
Message 4 of 14 in “Assorted comment fixes”
  1. 0/4 Assorted comment fixesHan-Wen Nienhuys, Sep 25, 2017
  2. 1/4 Fix typo in submodule.hHan-Wen Nienhuys, Sep 25, 2017
  3. 3/4 Document submodule_to_gitdirHan-Wen Nienhuys, Sep 25, 2017
  4. Brandon WilliamsSep 25, 2017
  5. 2/4 Clarify return value ownership of real_path and read_gitfile_gentlyHan-Wen Nienhuys, Sep 25, 2017
  6. Brandon WilliamsSep 25, 2017
  7. Junio C HamanoSep 26, 2017
  8. 4/4 Move documentation of string_list into string-list.hHan-Wen Nienhuys, Sep 25, 2017
  9. Brandon WilliamsSep 25, 2017
  10. Stefan BellerSep 25, 2017
  11. Andrey RybakSep 27, 2017
  12. Junio C HamanoSep 26, 2017
  13. Junio C HamanoSep 26, 2017
  14. Han-Wen NienhuysSep 26, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.